fix(cli): gate remaining dashboard URL prints behind is_verbose() for --silent compliance#211
Open
wjgong001 wants to merge 1 commit into
Open
fix(cli): gate remaining dashboard URL prints behind is_verbose() for --silent compliance#211wjgong001 wants to merge 1 commit into
wjgong001 wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to PR #203 (merged, by @sjh9714). PR #203 fixed the web-bg startup dashboard URL leak in
src/conductor/cli/app.py, but the--silentflag is supposed to suppress ALL dashboard URL output, not just the startup print.Remaining fixes
This PR gates the remaining dashboard URL prints behind
is_verbose():src/conductor/cli/run.py—run_workflow_asyncfunction (line 1174): The--silentflag should suppress this dashboard URL print during foreground --web runs, not just web-bg mode (fix(cli): suppress web-bg dashboard output in silent mode #203's scope).src/conductor/cli/run.py—resumefunction (line 1832): Same issue in the resume code path — dashboard URL printed regardless of --silent.src/conductor/cli/app.py—_run_replayfunction (line 994): Replay dashboard URL leaked even in --silent mode.src/conductor/cli/run.py— "Workflow complete. Dashboard still running at..." shutdown messages (lines 1321, 1884): Both therunandresumefunctions printed the dashboard URL during shutdown regardless of --silent mode.Testing
Existing tests from #203 should continue to pass. The fix follows the same pattern as #203: lazy-import
is_verbose()fromapp.pyand gate the print call.Co-authored-by: sjh9714 sjh9714@users.noreply.github.com